Commit c9d5261
committed
Fix feedback submission and form label accessibility bugs
- Fix feedback silently discarded when text is empty: Remove early return
that prevented submitFeedback.mutate() from being called when textarea
was empty. The thumbs up/down vote (isPositiveFeedback) is now recorded
even without optional text feedback.
- Fix form labels replaced with non-semantic paragraph elements: Replace
<p> tags with proper <Label> components with htmlFor attributes for the
Request, Subject, and Message form fields, restoring click-to-focus
behavior and screen reader association.1 parent e9b82ee commit c9d5261
File tree
2 files changed
+5
-9
lines changed- apps/sim/app/workspace/[workspaceId]
- components/message-actions
- w/components/sidebar/components/help-modal
2 files changed
+5
-9
lines changedLines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | 95 | | |
101 | 96 | | |
102 | 97 | | |
103 | 98 | | |
104 | 99 | | |
105 | | - | |
| 100 | + | |
106 | 101 | | |
107 | 102 | | |
108 | 103 | | |
| |||
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
431 | 432 | | |
432 | 433 | | |
433 | 434 | | |
434 | | - | |
| 435 | + | |
435 | 436 | | |
436 | 437 | | |
437 | 438 | | |
| |||
446 | 447 | | |
447 | 448 | | |
448 | 449 | | |
449 | | - | |
| 450 | + | |
450 | 451 | | |
451 | 452 | | |
452 | 453 | | |
| |||
456 | 457 | | |
457 | 458 | | |
458 | 459 | | |
459 | | - | |
| 460 | + | |
460 | 461 | | |
461 | 462 | | |
462 | 463 | | |
| |||
0 commit comments