Introduce PointerEvent.deviceProperties

sahirv · chromium-wpt-export-bot · commit f821fa78035e · 2024-03-28T16:13:05.000-07:00
This change replaces deviceId on the PointerEvent interface with a new interface, deviceProperties. DeviceProperties contains one member, uniqueId, which functionally behaves the same as the outgoing deviceId. Spec: w3c/pointerevents#495 This change also removes the setting of deviceId when creating a PointerCancel event, as there is no current application for device/unique id for a PointerCancel. Bug: 330760871 Change-Id: I0f1a9f7d5589f790d94f498a38bfdf55b6f51073
diff --git a/pointerevents/deviceproperties/get-device-properties-uniqueid-from-pointer-event.tentative.html b/pointerevents/deviceproperties/get-device-properties-uniqueid-from-pointer-event.tentative.html
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-actions.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
+
+<style>
+  div {
+    user-select: none; // Prevents text selection on drag.
+  }
+</style>
+<div id="logger" draggable="false"></div>
+<div id="console"></div>
+<!-- This test verifies that if the PointerEventDeviceId flag is enabled,
+     pointerEvent.deviceProperties.uniqueId is -1. If not, it is undefined. -->
+<script>
+    function CheckDeviceId(event) {
+        eventFired++;
+        assert_equals(event.deviceProperties.uniqueId, -1, "deviceId is -1");
+    }
+
+    window.addEventListener("pointerdown", CheckDeviceId, false);
+    window.addEventListener("pointermove", CheckDeviceId, false);
+
+    promise_test(async () => {
+        if (!window.internals)
+          return;
+        eventFired = 0;
+        let actions = new test_driver.Actions()
+          .addPointer("TestPointer", "pen")
+          .pointerDown()
+          .pointerMove(100, 100)
+          .pointerUp();
+
+        await actions.send();
+
+        assert_true(eventFired == 2);
+    }, 'PointerEvent.deviceProperties.uniqueId');
+</script>
diff --git a/pointerevents/deviceproperties/pointer-event-has-device-properties-uniqueid-from-pointer-event-init.tentative.html b/pointerevents/deviceproperties/pointer-event-has-device-properties-uniqueid-from-pointer-event-init.tentative.html
@@ -0,0 +1,54 @@
+<!DOCTYPE html>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<div id="console"></div>
+
+<!-- This test verifies that if the kPointerEventDeviceId flag is enabled,
+     pointerEvent.deviceProperties.uniqueId can be set via PointerEventInit. If not, it is
+     undefined. -->
+<script>
+    function CheckDeviceId(event) {
+        assert_equals(event.deviceProperties.uniqueId, 1001, "uniqueId is populated");
+    }
+
+    promise_test(async () => {
+        if (!window.internals)
+          return;
+        var deviceProps = new DeviceProperties({
+          uniqueId: 1001
+        });
+        var downEvent = new PointerEvent("pointerdown",
+          {pointerId: 1,
+            bubbles: true,
+            cancelable: true,
+            pointerType: "pen",
+            width: 100,
+            height: 100,
+            isPrimary: true,
+            deviceProperties: deviceProps
+          });
+        CheckDeviceId(downEvent);
+        var moveEvent = new PointerEvent("pointermove",
+          {pointerId: 1,
+            bubbles: true,
+            cancelable: true,
+            pointerType: "pen",
+            width: 100,
+            height: 100,
+            isPrimary: true,
+            deviceProperties: deviceProps
+          });
+        CheckDeviceId(moveEvent);
+        var upEvent = new PointerEvent("pointerup",
+          {pointerId: 1,
+            bubbles: true,
+            cancelable: true,
+            pointerType: "pen",
+            width: 100,
+            height: 100,
+            isPrimary: true,
+            deviceProperties: deviceProps
+          });
+        CheckDeviceId(upEvent);
+    }, 'PointerEvent.deviceId via PointerEventInit');
+</script>
