Fix: handle zero input in binary_count_trailing_zeros#14510
Open
kadambari25 wants to merge 3 commits intoTheAlgorithms:masterfrom
Open
Fix: handle zero input in binary_count_trailing_zeros#14510kadambari25 wants to merge 3 commits intoTheAlgorithms:masterfrom
kadambari25 wants to merge 3 commits intoTheAlgorithms:masterfrom
Conversation
bcf8625 to
dd91001
Compare
for more information, see https://un5qe1qjky490yygzvv0.julianrbryant.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the function
binary_count_trailing_zeros.Previously, the function returned
0for input value0. However, mathematically, trailing zeros for0are undefined, and returning0can lead to incorrect behavior in dependent algorithms.Changes made
0ValueErrorwhen input is zeroFixes #14479
Type of change
Checklist: