Skip to content

fix(@angular/build): respect sourceMap configuration in dev server #32941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maruthang wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −5
Open

fix(@angular/build): respect sourceMap configuration in dev server #32941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/angular/build/src/builders/dev-server/vite/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,11 @@ export async function* serveWithVite(
browserOptions.forceI18nFlatOutput = true;
}

const { vendor: thirdPartySourcemaps, scripts: scriptsSourcemaps } = normalizeSourceMaps(
browserOptions.sourceMap ?? false,
);
const {
vendor: thirdPartySourcemaps,
scripts: scriptsSourcemaps,
styles: stylesSourcemaps,
} = normalizeSourceMaps(browserOptions.sourceMap ?? false);

if (scriptsSourcemaps && browserOptions.server) {
// https://un5zrke0g2qx6zm5.julianrbryant.com/api/process.html#processsetsourcemapsenabledval
Expand Down Expand Up @@ -184,7 +186,7 @@ export async function* serveWithVite(
// Always enable JIT linking to support applications built with and without AOT.
// In a development environment the additional scope information does not
// have a negative effect unlike production where final output size is relevant.
{ sourcemap: true, jit: true, thirdPartySourcemaps },
{ sourcemap: scriptsSourcemaps, jit: true, thirdPartySourcemaps },
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The prebundleTransformer is used specifically for third-party dependencies during the Vite prebundling process. It should therefore respect the thirdPartySourcemaps (which corresponds to the vendor source map setting) rather than scriptsSourcemaps for its internal sourcemap generation toggle.

Using scriptsSourcemaps here means that if a user has "sourceMap": true (which defaults vendor to false in Angular), source maps will still be generated for prebundled third-party packages, which contradicts the configuration and the stated goal of this PR to avoid injecting source maps when disabled.

Suggested change
{ sourcemap: scriptsSourcemaps, jit: true, thirdPartySourcemaps },
{ sourcemap: thirdPartySourcemaps, jit: true, thirdPartySourcemaps },

1,
);

Expand Down Expand Up @@ -428,6 +430,7 @@ export async function* serveWithVite(
extensions?.middleware,
transformers?.indexHtml,
thirdPartySourcemaps,
stylesSourcemaps,
);

server = await createServer(serverConfiguration);
Expand Down
3 changes: 2 additions & 1 deletion packages/angular/build/src/builders/dev-server/vite/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export async function setupServer(
extensionMiddleware?: Connect.NextHandleFunction[],
indexHtmlTransformer?: (content: string) => Promise<string>,
thirdPartySourcemaps = false,
stylesSourcemaps = true,
): Promise<InlineConfig> {
const { normalizePath } = await import('vite');

Expand Down Expand Up @@ -175,7 +176,7 @@ export async function setupServer(
// We use custom as we do not rely on Vite's htmlFallbackMiddleware and indexHtmlMiddleware.
appType: 'custom',
css: {
devSourcemap: true,
devSourcemap: stylesSourcemaps,
},
// Ensure custom 'file' loader build option entries are handled by Vite in application code that
// reference third-party libraries. Relative usage is handled directly by the build and not Vite.
Expand Down
Loading