fix(@angular/build): isolate Vite cache per build configuration in dev server#32944
Open
maruthang wants to merge 1 commit intoangular:mainfrom
Open
fix(@angular/build): isolate Vite cache per build configuration in dev server#32944maruthang wants to merge 1 commit intoangular:mainfrom
maruthang wants to merge 1 commit intoangular:mainfrom
Conversation
…v server Running two ng serve instances for the same project with different configurations (e.g., different locales) caused "504 Outdated Optimize Dep" errors because both instances shared the same Vite optimizer cache directory. The fix includes the build configuration name in the Vite cache directory path, preventing cache conflicts between concurrent dev server instances. Closes angular#31700
There was a problem hiding this comment.
Code Review
This pull request updates the Vite dev server configuration to include the build configuration in the cache path. This change prevents potential conflicts when running multiple dev server instances with different configurations. I have no further feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ng serveinstances for the same project with different configurations (e.g., different locales) caused "504 Outdated Optimize Dep" errors<cache>/<project>/vite), so when one instance updated the cache, the other detected stale metadata<cache>/<project>/vite/<configuration>), isolating each instance's cacheCloses #31700
Test plan
ng serveinstances with different configurations concurrently — no 504 errorsng serveinstance still works correctly