Introduce configurable timeout to Create NAS backup

[abh1sar]

Description

Create backup used to take the default cmds.timeout (7200s) in agent.properties as the timeout.
This might not be enough for large images and slow networks.
Adding a configurable timeout for create backup.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1. Decreased timeout to 10s
2. Backup failed
3. Increased timeout to 300
4. Backup was taken successfully

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (59b6c32) to head (22eb362).
⚠️ Report is 3 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...ce/wrapper/LibvirtRestoreBackupCommandWrapper.java	33.33%	1 Missing and 1 partial ⚠️
...ource/wrapper/LibvirtTakeBackupCommandWrapper.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12964      +/-   ##
============================================
- Coverage     17.60%   17.60%   -0.01%     
+ Complexity    15676    15675       -1     
============================================
  Files          5918     5918              
  Lines        531667   531682      +15     
  Branches      65001    65007       +6     
============================================
- Hits          93617    93614       -3     
- Misses       427491   427506      +15     
- Partials      10559    10562       +3     

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	18.67% <20.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

@abh1sar can this be addressed with the value 'TakeBackupCommand=14400' in commands.timeout global config? if so, we can document it and skip this new timeout config?

[abh1sar]

Thanks @sureshanaparti . I'll test with commands.timeout and update

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17365