refactor: eliminate internal globals in favor of store singleton#5506
Open
refactor: eliminate internal globals in favor of store singleton#5506
Conversation
…direct imports Replace all internal global variable usage with proper ESM patterns: - Add store.initialize() method with immutable required fields (codeceptDir, outputDir, workerMode) - Replace global.codecept_dir/output_dir reads with store.codeceptDir/outputDir (~55 sites) - Replace global.container reads with direct container imports (~15 sites) - Replace global.debugMode with store.debugMode in WebDriver/Puppeteer - Replace process.env.RUNS_WITH_WORKERS with store.workerMode - Replace process.env.FEATURE_ONLY/SCENARIO_ONLY with store.featureOnly/scenarioOnly - Replace global.maskSensitiveData with store.maskSensitiveData - Convert singleton guard globals to module-level variables - Remove dead global.codecept_debug - Keep user-facing DSL globals (Feature, Scenario, etc.) and backward compat writes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ration These were set in 3.x codecept.js but never ported to 4.x globals.js. Needed for CJS helpers that use `const Helper = codecept_helper`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- noGlobals: true skips ALL globals including Mocha DSL (Feature, Scenario, etc.) - noGlobals: false (default for existing projects) prints deprecation warning - New projects generated via `codeceptjs init` get noGlobals: true by default - Store noGlobals flag in store so initMochaGlobals respects it Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
store.initialize()with immutable required fields (codeceptDir,outputDir,workerMode) that are frozen viaObject.definePropertyafter initializationglobal.*reads withstoreproperties or direct ESM imports (~70 call sites across 44 files)process.envflags (RUNS_WITH_WORKERS,FEATURE_ONLY,SCENARIO_ONLY) to store session configFeature,Scenario,Before, etc.) and backward-compat writes for external pluginsStore field categories
codeceptDir,outputDir,workerModeinitialize(), frozen, never cleareddebugMode,timeouts,autoRetries,dryRun,featureOnly,scenarioOnly,maskSensitiveDataonPause,currentTest,currentStep,currentSuiteWhat was eliminated
global.codecept_dirstore.codeceptDirglobal.output_dirstore.outputDirglobal.containerimport containerglobal.debugModestore.debugModeglobal.__playwrightSelectorsRegisteredletglobal.__codeceptConfigListenerInitializedletglobal.codecept_debugprocess.env.RUNS_WITH_WORKERSstore.workerModeprocess.env.FEATURE_ONLYstore.featureOnlyprocess.env.SCENARIO_ONLYstore.scenarioOnlyglobal.maskSensitiveDatastore.maskSensitiveDataTest plan
store.initialize()freezes required fields (verified with direct test)🤖 Generated with Claude Code