Docs: Update screenshots of variant analysis results view#14051
Merged
shati-patel merged 1 commit intomainfrom Aug 25, 2023
Merged
Docs: Update screenshots of variant analysis results view#14051shati-patel merged 1 commit intomainfrom
shati-patel merged 1 commit intomainfrom
Conversation
3 tasks
Contributor
|
Should we also update the text to mention something about the new dropdown? |
Contributor
Author
Good question! Since we don't explicitly mention the other dropdowns in the docs either, I'd err on the side of "less is more" 😆 and not mention the new one either. (Docs team, please let me know if you'd like a text update too though!) |
subatoi
approved these changes
Aug 25, 2023
Contributor
subatoi
left a comment
There was a problem hiding this comment.
Thanks, @shati-patel! I'll ping @felicitymay here (who is back next week): she can decide whether to open a follow-up issue around adding text, but I see no reason not to merge this now 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've added a new dropdown to the results view in github/vscode-codeql#2745.
This PR updates a few screenshots from https://un5kwke0ketx6vwhy3c87d8.julianrbryant.com/docs/codeql-for-visual-studio-code/running-codeql-queries-at-scale-with-mrva/#exploring-your-results
I've gone for a smaller screenshot (as per the guidance from #13821 (review)), and for the other image I just manually edited it 🤫
This has minor docs impact, so can be merged/released any time!