Update about-telemetry-in-codeql-for-visual-studio-code.rst to mention telemtry.telemetryLevel#14408
Merged
robertbrignull merged 1 commit intomainfrom Oct 9, 2023
Merged
Conversation
…n telemtry.telemetryLevel
This was referenced Oct 9, 2023
Merged
shati-patel
approved these changes
Oct 9, 2023
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Looks good to me! No need to mention the old setting 👌🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recommended setting to use is now
telemetry.telemetryLevel.See github/vscode-codeql#2824 which implemented this change in the extension (currently not released as of writing).
I considered still mentioning the old setting because the extension currently respects both. But the microsoft documentation we link to only mentions the new setting, so I decided to follow that example.