Add note about telemetry for CodeQL extension settings#15333
Add note about telemetry for CodeQL extension settings#15333shati-patel merged 1 commit intomainfrom
Conversation
|
Please don't forget that a non-zero amount of people has likely disabled telemetry. |
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM with one non-blocking thought I had
| - Randomly generated GUID that uniquely identifies a CodeQL extension installation. (Discarded before aggregation.) | ||
| - IP address of the client sending the telemetry data. (Discarded before aggregation.) | ||
| - Whether or not the ``codeQL.canary`` setting is enabled and set to ``true``. | ||
| - Whether any :doc:`CodeQL extension settings <customizing-settings>` are configured. |
There was a problem hiding this comment.
codeQL.canary is also a CodeQL extension setting, so from a technical perspective it's odd to mention them in two separate lines. But I don't know what's more understandable for the user. I thought I'd mention this, but I think what's written here already is a perfectly fine explanation.
There was a problem hiding this comment.
Yep, I wondered about that too! @jf205, any preference on whether we continue to call out the canary setting separately, or just include the general line about settings?
|
Merging this now, we can always adjust the wording later. |
We plan to start collecting telemetry about which settings users are using in the CodeQL extension for VS Code, to help inform which features are useful or not. We currently only check for the
codeQL.canarysetting, but we'd like to extend this to others too, hence the slight change in wording!For example, an upcoming change (github/vscode-codeql#3238) will add telemetry for the
codeQL.addingDatabases.addDatabaseSourceToWorkspacesetting.