Skip to content

[Already shipped] Docs: Update setting in CodeQL for VS Code#6072

Merged
shati-patel merged 1 commit intogithub:mainfrom
shati-patel:shati-patel/vs-code-setting
Jun 21, 2021
Merged

[Already shipped] Docs: Update setting in CodeQL for VS Code#6072
shati-patel merged 1 commit intogithub:mainfrom
shati-patel:shati-patel/vs-code-setting

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Jun 14, 2021

Just a one-line change!

In release v1.5.0 of CodeQL for VS Code, we support "workspace trust", which is a new(ish) VS Code feature that lets users explicitly mark workspaces as safe.

Therefore, we no longer restrict the CLI Executable Path setting in safe workspaces. In untrusted workspaces, the VS Code UI displays a clear warning message, so I don't think we need to document this on our end. Example:
image


Associated issue: github/vscode-codeql#849
Implemented in: github/vscode-codeql#861

@shati-patel shati-patel added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Jun 14, 2021
@shati-patel shati-patel changed the title Docs: Update setting in CodeQL for VS Code [Already shipped] Docs: Update setting in CodeQL for VS Code Jun 14, 2021
Copy link
Copy Markdown

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@shati-patel shati-patel merged commit bbb5a39 into github:main Jun 21, 2021
@shati-patel shati-patel deleted the shati-patel/vs-code-setting branch June 21, 2021 07:34
@shati-patel shati-patel removed the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants