Skip to content

Don't prompt to download database for this repo#28

Merged
shati-patel merged 2 commits intomainfrom
disable-db-download
Feb 7, 2024
Merged

Don't prompt to download database for this repo#28
shati-patel merged 2 commits intomainfrom
disable-db-download

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

The recent changes for a "repo-centric setup" in the extension means that we get a pop-up to download a CodeQL database for the current repository:

image

This somewhat breaks the flow of the code tour tutorial, so I suggest that we disable the prompt in this case. (I can't imagine anyone usefully needing to run queries on github/codespaces-codeql for now.)

@shati-patel shati-patel requested a review from a team as a code owner February 7, 2024 12:53
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense!

Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com>
@shati-patel shati-patel merged commit e080809 into main Feb 7, 2024
@shati-patel shati-patel deleted the disable-db-download branch February 7, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants