Merged
Conversation
2bff0d8 to
1d6585d
Compare
aeisenberg
reviewed
Feb 16, 2023
elenatanasoiu
added a commit
to github/vscode-codeql
that referenced
this pull request
Feb 16, 2023
Is required by this PR: github/codespaces-codeql#6
aeisenberg
approved these changes
Feb 16, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
I think this looks fine to me, with the caveat of my previous comment and also that this is still experimental and we need to see how this works.
We're going to get rid of this folder, but we want to keep these two files so that we're able to run our query in `tutorial.ql`. So we're moving these files in `tutorial-queries`.
Since we're deleting tutorial-lib, we'll need a way to point at our dbscheme. We were initially doing this in tutorial-lib/qlpack.yml. We're now doing this in tutorial-queries/qlpack.yml.
0206ad2 to
c8e4d43
Compare
So that we can take advantage of any newer versions.
aeisenberg
approved these changes
Feb 21, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Nice. Based on our pairing session, this is working.
shati-patel
added a commit
that referenced
this pull request
Mar 17, 2023
We no longer need to copy these files over as of #6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: github/vscode-codeql#2090
When a user goes through the Code Tour, we select a dummy
csvdatabasefor them to get them up and running.
Once they complete the code tour and would like to continue writing
queries, they will need to add their own database.
After they do that, we check the language of their new database and
generate a skeleton QL pack for them so that they don't need to create
these files by hand. See 1 for details.
This skeleton pack folder will be called
codeql-custom-queries-<language>and it comes with its own examplequery:
example.ql.When we try to run this example query, the query gets confused about
which
dbschemeto pick, as it sees aqlpack.ymlfile in the newskeleton pack folder, as well as one in the existing
tutorial-libfolder.
So we'll need to get rid of the
tutorial-libfolder in order to make roomfor new queries to be run once the tour is complete.
This also depends on triggering a
codeql pack installcommand inorder to install real library dependencies for
tutorial-queries, since we nolonger have the dummy library in
tutorial-lib.