Merged
Conversation
Successfully completed queries will be stored on disk and available across restarts. - The query results are contained in global storage. - Metadata and a summary about a query are stored in workspace storage. - There is a job that runs every 2 hours to determine if any queries are old enough to be deleted.
aeisenberg
commented
Feb 9, 2022
charisk
reviewed
Feb 10, 2022
| await query.createTimestampFile(); | ||
|
|
||
| const upgradeDir = await tmp.dir({ dir: upgradesTmpDir.name, unsafeCleanup: true }); | ||
| let upgradeDir: tmp.DirectoryResult | undefined; |
Contributor
There was a problem hiding this comment.
Is this change relevant to query history? 🤔
- Rename queryStorageLocation -> queryStorageDir - Extract scrubber to its own module - Add more comments - Rename source -> cancellationSource - Ensure cancellatinSource is disposed
charisk
reviewed
Feb 14, 2022
charisk
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successfully completed queries will be stored on disk and available
across restarts.
old enough to be deleted.
Checklist
ready-for-doc-reviewlabel there.