Ensure --addtional-packs arg not used for empty workspace#1157
Merged
aeisenberg merged 1 commit intomainfrom Feb 22, 2022
Merged
Ensure --addtional-packs arg not used for empty workspace#1157aeisenberg merged 1 commit intomainfrom
--addtional-packs arg not used for empty workspace#1157aeisenberg merged 1 commit intomainfrom
Conversation
b0e5338 to
251f354
Compare
henrymercer
approved these changes
Feb 21, 2022
| } | ||
| } | ||
|
|
||
| private getAdditionalPacksArg(paths: string[]): string[] { |
Contributor
There was a problem hiding this comment.
Minor: Is Args more appropriate here since the return type is an array?
Contributor
Author
There was a problem hiding this comment.
I used Arg (singular) since this method returns the --additional-packs argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1066
Checklist
ready-for-doc-reviewlabel there.