Save log files to the query history directory#1178
Merged
aeisenberg merged 4 commits intomainfrom Mar 3, 2022
Merged
Conversation
Contributor
Author
|
@edoardopirovano, @angelapwen, the changes here should make it easier to store structured logs in each query history folder. I would have done it myself, but I wasn't sure how to specify a different log file per query. |
4303608 to
3b6021b
Compare
shati-patel
approved these changes
Mar 2, 2022
Contributor
edoardopirovano
left a comment
There was a problem hiding this comment.
In addition Shati's comments, a minor typo I spotted.
| } | ||
|
|
||
| public activeQueryName: string | undefined; | ||
| public activeQueryLogFIle: string | undefined; |
This commit deprecates the the cutsom log directory option by saving all log files with query history. There is a simplification of the `OutputChannelLogger` since it no longer needs to manage deleting log files on exit. Also, the `codeQL.runningQueries.customLogDirectory` is marked as deprecated. If this value is being used, a warning message is popped up after the query completes.
b4f63e8 to
b2b8625
Compare
b2b8625 to
f28c1f9
Compare
Allows users to explore the contents and all artifacts of the query that was just run.
Add new command to open the query history directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deprecates the the cutsom log directory option by saving
all log files with query history.
There is a simplification of the
OutputChannelLoggersince it nolonger needs to manage deleting log files on exit.
Also, the
codeQL.runningQueries.customLogDirectoryis marked asdeprecated. If this value is being used, a warning message is popped
up after the query completes.
Fixes #1174
Checklist
ready-for-doc-reviewlabel there.