Fix error messages in extension log when quick evalling library files with CodeQL CLI v2.10.0#1412
Merged
edoardopirovano merged 3 commits intomainfrom Jun 29, 2022
Conversation
Currently `resolve ml-models` only supports queryspecs, i.e. .ql, .qls, directory, and query pack specifications. Therefore quick evaluation within a library isn't supported.
edoardopirovano
approved these changes
Jun 29, 2022
Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
resolve ml-modelsonly supports queryspecs, i.e. .ql, .qls, directory, and query pack specifications. However, a quick evaluation within a library will have a path ending in .qll, and currently the extension tries to callresolve ml-modelson this path, logging an error message like this to the extension log:With this PR, we no longer try to resolve ML models when doing a quick evaluation within a library. Instead, we print an informative message "Quick evaluation within a query library does not currently support using ML models. Continuing without any ML models." to the extension log.
Checklist
ready-for-doc-reviewlabel there.