Skip to content

Don't display destructive upgrades any more.#1501

Merged
adityasharad merged 3 commits intogithub:mainfrom
alexet:alexet/no-display-destructive-upgrades
Sep 8, 2022
Merged

Don't display destructive upgrades any more.#1501
adityasharad merged 3 commits intogithub:mainfrom
alexet:alexet/no-display-destructive-upgrades

Conversation

@alexet
Copy link
Copy Markdown

@alexet alexet commented Sep 7, 2022

Most users don't want to destructively upgrade their database any more. This hides the option from the right click menu. It is still visible in the command picker for those users who actually want to do that.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@alexet alexet marked this pull request as ready for review September 7, 2022 13:35
@alexet alexet requested a review from a team as a code owner September 7, 2022 13:35
Copy link
Copy Markdown
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I've done a quick search of our documentation and found no references to this. Perhaps there's some other documentation my search missed, though.

@alexet
Copy link
Copy Markdown
Author

alexet commented Sep 7, 2022

Do we want a change log entry for this. It is certainly user visible? I can write one if we do.

@adityasharad
Copy link
Copy Markdown
Contributor

A brief change note sounds good. Mention the command has been removed from the context menu and is no longer necessary.

@alexet
Copy link
Copy Markdown
Author

alexet commented Sep 8, 2022

I have written a change note.

@alexet alexet force-pushed the alexet/no-display-destructive-upgrades branch from 66d1b8f to 5bc162e Compare September 8, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants