Use better heuristics when checking db folders#1565
Merged
aeisenberg merged 2 commits intomainfrom Oct 3, 2022
Merged
Conversation
77eb83e to
54ba5ce
Compare
angelapwen
approved these changes
Oct 3, 2022
Contributor
angelapwen
left a comment
There was a problem hiding this comment.
Makes sense! The tests make the functionality very clear 😸
extensions/ql-vscode/src/vscode-tests/no-workspace/helpers.test.ts
Outdated
Show resolved
Hide resolved
…t.ts Co-authored-by: Angela P Wen <angelapwen@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix that allows users to add databases even if the database root folder starts with
db-.Fixes #1561
Checklist
ready-for-doc-reviewlabel there.