Merged
Conversation
We added a `successful` property to serialized local queries. But, this property does not exist on older serialized queries. This change ensures older queries get a `successful` property when deserialized.
charisk
approved these changes
Oct 14, 2022
alexet
approved these changes
Oct 14, 2022
Contributor
|
Thanks @aeisenberg! ❤️ That was a more damaging typo fix than I'd realised 😅 |
Contributor
Author
|
There were actually two issues here. Not just the typo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added a
successfulproperty to serialized local queries. But, this property does not exist on older serialized queries. This change ensures older queries get asuccessfulproperty when deserialized.Clearly, our (de-)serialization tests are not sufficient. After this change goes in, I'll add some new tests for it. I've tried this out locally and this change is working.
Checklist
ready-for-doc-reviewlabel there.