Assert VSCode version is high enough#1674
Merged
aeisenberg merged 6 commits intomainfrom Nov 15, 2022
Merged
Conversation
3 tasks
henrymercer
approved these changes
Oct 31, 2022
Contributor
Do we have any telemetry information about which VS Code version our users are on? |
Contributor
Author
|
The telemetry is not easy to access at the moment, but it looks like about 4.5% of the users who are sending telemetry are below v1.67 (and would be affected by this change). I think the key thing to do here is to only ask them to upgrade once in a while (perhaps whenever they upgrade the extension). I'll work on that later in this PR. |
Contributor
Author
|
Better approach will be to continue to show this message on every restart, and also have a "Don't show this again" button. |
Version checks are re-enabled whenever the version of vscode changes. This is because the user would have needed to manually update their vscode version in order to get this new version. And another failing version check would mean there is a newer version that needs to be downloaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change to verify that the vscode version is high enough to support some future features.
Before bumping the
engineproperty of package.json, we will need to first bump the min version in extension.ts, then release that bumped version. Once that extension version is available, people on older versions will get warnings that they need to upgrade. Then we can release a new version of vscode that requires a new minimum version.Update: Added a way to disable version checks
Version checks are re-enabled whenever the version of vscode changes.
This is because the user would have needed to manually update their
vscode version in order to get this new version. And another failing
version check would mean there is a newer version that needs to be
downloaded.
Checklist
ready-for-doc-reviewlabel there.