Merged
Conversation
elenatanasoiu
approved these changes
Nov 25, 2022
This removes all CodeQL CLI version constraints for unsupported CLI versions (< 2.7.6). The oldest supported CLI version is 2.7.6 since GHES 3.3 recommends using CodeQL CLI 2.7.6.
ef6686c to
140d369
Compare
Member
Author
|
@aeisenberg Would you be able to confirm that we're not supporting the older 2.7 minor versions anymore? |
Contributor
|
Yes. That's exactly right. 2.7.6 is the earliest version we need to support. |
aeisenberg
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all CodeQL CLI version constraints for unsupported CLI versions (< 2.7.6). The oldest supported CLI version is 2.7.6 since GHES 3.4 recommends using CodeQL CLI 2.7.6.
I've also removed a constraint on version 2.7.1, but I'm not sure if we still support all 2.7.x versions.
Please double check that I made the correct transformations in call-sites, especially with regards to if conditions being
true/false.Checklist
ready-for-doc-reviewlabel there.