Skip to content

Minor polish to the "bump CLI" automation#1996

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/tweak-cli-workflow
Jan 20, 2023
Merged

Minor polish to the "bump CLI" automation#1996
shati-patel merged 2 commits intomainfrom
shati-patel/tweak-cli-workflow

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

We took @tjgurwara99's new bump-cli workflow for its first test run in #1995, which worked great! 🙏🏽 🎉

This PR polished a few minor things noticed during testing: 💅🏽

  • Tell Prettier to ignore supported_cli_versions.json when linting/formatting
  • Open the generated PR as a draft: CI doesn't run on PRs opened by the github-actions bot, so we need a human to manually prod them. Our existing approach (e.g. in the releases workflow) is to open the bot PR as a draft, and then run CI when a human marks it as ready-for-review.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

CI doesn't run on PRs opened by the github-actions bot, so we need a human to manually prod them. Our existing approach (e.g. in the releases workflow) is to open the bot PR as a draft, and then run CI when a human marks it as ready-for-review.
@shati-patel shati-patel requested a review from a team as a code owner January 20, 2023 18:10
@shati-patel shati-patel merged commit 2c19b32 into main Jan 20, 2023
@shati-patel shati-patel deleted the shati-patel/tweak-cli-workflow branch January 20, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants