Update export/copy buttons copy when repositories are selected#2427
Merged
Update export/copy buttons copy when repositories are selected#2427
Conversation
This changes the text of the export/copy buttons on a variant analysis when at least one repository is selected. This makes it more clear that the user is only exporting/copying the results of the selected repositories.
When the user filters the repositories, the buttons should reflect that the results are filtered and that the user is not exporting or copying all the results. If the user has selected repositories, the buttons should still say that they are exporting selected results.
shati-patel
approved these changes
May 17, 2023
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Could you add a changelog entry? Looks great otherwise!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the text of the export/copy buttons on a variant analysis when at least one repository is selected or a filter is applied which filters out part of the repositories. This makes it more clear that the user is only exporting/copying the results of the selected/filtered repositories.
Screen.Recording.2023-05-17.at.15.10.08.mov
Checklist
ready-for-doc-reviewlabel there.