Skip to content

Bump minimum VS Code version to 1.82#2854

Merged
koesie10 merged 1 commit intomainfrom
koesie10/bump-min-version
Sep 28, 2023
Merged

Bump minimum VS Code version to 1.82#2854
koesie10 merged 1 commit intomainfrom
koesie10/bump-min-version

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Sep 25, 2023

This changes the MIN_VERSION that will be used for showing warnings to 1.82.0. 1.82 is the August release (currently the latest) and upgrades to Node.js 18. We would like to be able to upgrade to dependencies that require Node.js 18, so let's set the minimum supported version to this so we can drop support for older versions after the next release.

We can't really upgrade to a newer VS Code version for integration tests until we fully support Node.js 18, but that means dropping support for running integration tests on Node.js 16. Therefore, we need to merge this before doing our upgrade to a newer VS Code and Node.js version.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review September 28, 2023 12:00
@koesie10 koesie10 requested a review from a team as a code owner September 28, 2023 12:00
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍🏽

@koesie10 koesie10 merged commit 469f65a into main Sep 28, 2023
@koesie10 koesie10 deleted the koesie10/bump-min-version branch September 28, 2023 14:04
@koesie10 koesie10 mentioned this pull request Oct 2, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants