Use streaming when creating log symbols file.#2858
Merged
Conversation
aeisenberg
reviewed
Sep 25, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Looks reasonable to me. Do we have any tests for SplitBuffer?
| * https://un5j2j18xhuv2emkwgjjkgb49yug.julianrbryant.com/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith | ||
| * which is CC0/public domain | ||
| * | ||
| * See https://github.com/github/vscode-codeql/issues/802 for more context as to why we need it. |
Contributor
There was a problem hiding this comment.
Looks like the upstream issues have been fixed. Maybe we can remove this workaround. (Not needed for this PR.)
Contributor
There was a problem hiding this comment.
Is there anything in this file that has changed when you extracted it?
Contributor
Author
There was a problem hiding this comment.
No, other than the casing of LINE_ENDINGS.
Contributor
Author
There was a problem hiding this comment.
Oh, and the bug I discovered when you made me write a unit test:)
aeisenberg
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal users were seeing frequent crashes complaining about trying to create a string that was too long to fit in memory. This was happening when we parse the human-readable log to generate the symbols that map predicates to their human-readable RA. We were simply reading the entire human-readable log into memory at once, and these can be extremely large for complex queries.
The fix was to just use a streaming reader, which required slightly rearranging the code we use to parse the lines coming out of the reader.
I also moved some existing code for splitting a stream at line break boundaries into its own source file, so we could consume it from the new code.