Hash result set name in sorted result set path#2955
Merged
Conversation
f634945 to
6d1b01d
Compare
Contributor
Author
|
Build failures should be resolved by #2962. |
koesie10
reviewed
Oct 12, 2023
Member
koesie10
left a comment
There was a problem hiding this comment.
Thanks for implementing this! I have some questions about MurmurHash, but the general implementation looks good.
6d1b01d to
ee5b738
Compare
koesie10
approved these changes
Oct 12, 2023
Member
koesie10
left a comment
There was a problem hiding this comment.
Thank you for implementing those changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the filename used for sorted result sets from using the result set name directly to using a hash. Using a hash is preferable as the result set names are generated from the named results of the final stage. It is therefore partially under user-control and may contain additional special characters that cannot be used in filenames as the RA name character set is extended.
Checklist
ready-for-doc-reviewlabel there.