Fix empty message with empty SARIF path#3018
Merged
Conversation
charisk
approved these changes
Oct 25, 2023
Contributor
charisk
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding the story.
Contributor
|
Shall we add a CHANGELOG entry and merge for today's release? |
charisk
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an empty message when the SARIF artifact location is
file://. I've also added it to a story to see it locally without running a query.Before:
After:
Query that shows this problem:
cpp/ql/src/Security/CWE/CWE-079/CgiXss.qlwithkirxkirx/vast.Closes #1357
Checklist
ready-for-doc-reviewlabel there.