Skip to content

Rename "allowHttp" setting#3069

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/rename-setting
Nov 14, 2023
Merged

Rename "allowHttp" setting#3069
shati-patel merged 2 commits intomainfrom
shati-patel/rename-setting

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

Follow up to #3047 to properly rename this setting and deprecate the old name!

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Both names will be supported for a few releases, then we'll remove the old name.
@shati-patel shati-patel marked this pull request as ready for review November 14, 2023 11:31
@shati-patel shati-patel requested a review from a team as a code owner November 14, 2023 11:31
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shati-patel shati-patel enabled auto-merge (squash) November 14, 2023 11:33
@shati-patel shati-patel merged commit 1440339 into main Nov 14, 2023
@shati-patel shati-patel deleted the shati-patel/rename-setting branch November 14, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants