Change dataflow and taint-tracking snippets to match the module-based API#3091
Merged
robertbrignull merged 3 commits intogithub:mainfrom Nov 27, 2023
Conversation
MathiasVP
commented
Nov 24, 2023
robertbrignull
approved these changes
Nov 27, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
One comment on whitespace in the snippet, but looks good to me either way.
Contributor
Author
|
@robertbrignull I believe I've addressed all your comments (thanks for them!). Do you mind re-approving? 🙏 |
robertbrignull
approved these changes
Nov 27, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
Sure, can do so it's explicit 👍🏼
Though it isn't technically needed for this repo. The earlier review is still valid and allows merging.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The snippets were expanding to the old class-based dataflow API which we don't want users to use anymore.
This PR updates those snippets to expand to the new module-based API:
Checklist
ready-for-doc-reviewlabel there.