Merged
Conversation
charisk
approved these changes
Dec 6, 2023
Contributor
charisk
left a comment
There was a problem hiding this comment.
LGTM! Do we need to update the CHANGELOG?
Member
Author
Good idea, I'll add this fix to the CHANGELOG. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loading message for the compare view was never shown because the
comparisonwas neverundefined/null. This changes the comparison to benullon load to make sure that we explicitly handle this case rather than relying on an empty comparison message. This helps when there is a large number of results and loading them takes a while.Checklist
ready-for-doc-reviewlabel there.