CodeQL model editor: Make "add" and "delete" buttons more intuitive#3123
CodeQL model editor: Make "add" and "delete" buttons more intuitive#3123shati-patel merged 1 commit intomainfrom
Conversation
|
Some of the Windows tests are failing with I'm not quite sure why... It's similar to the errors I've been getting locally though (also on Windows) 🤷🏽 |
robertbrignull
left a comment
There was a problem hiding this comment.
Changes LGTM
I assume the windows test failures are random and not related to this PR. If they keep happening after retrying a few times we can look into whether this PR is special or look into fixing them generally.
norascheuch
left a comment
There was a problem hiding this comment.
I love this change!! I always found it super confusing that the last item wasn't deletable :D (Can you paste a screenshot of the new design to see a before - after?)
|
Tests finally passed after a few re-runs 🙃 🎉
Good idea! I've added a before/after to the PR description ❤️ |
A minor UI suggestion for adding multiple models in the model editor. Previously, you'd click the last row of the model editor to add a new row, and then all other rows would become deletable, except that new empty one. We decided that it's slightly more helpful to have the first row remaining fixed (and undeletable).
Before:

After:

Checklist
ready-for-doc-reviewlabel there.