Avoid creating a multitoken when finding definitions#3125
Merged
aeisenberg merged 2 commits intomainfrom Dec 13, 2023
Merged
Conversation
robertbrignull
approved these changes
Dec 12, 2023
Contributor
I don't have strong opinions on what the behaviour should. I'm very happy to trust your judgement as you use this particular feature a lot more and are closer to the users. I think the code changes look fine. |
Contributor
Author
|
Thanks. I'll add a changelog note and then merge. I'm assuming the two failing jobs are flakes. |
This will avoid showing a query-server popup on hovers. When someone does CTRL+hover on source code in a database archive, the definitions provider is triggered. The first time this is run, there will be a query that is invoked in order to find definitions. This can be a long process. Previously, this query brought up a popup window that could be cancelled. However, this is confusing users since the query is automatically cancelled when the mouse hovers away from the element. The downside of this PR is that even when find definitions is explicitly invoked, (using F12), there will still be no hover. I think this is an improvement, but I am happy to discuss if others disagree.
a8cf1f4 to
8516940
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will avoid showing a query-server popup on hovers. When someone does CTRL+hover on source code in a database archive, the definitions provider is triggered. The first time this is run, there will be a query that is invoked in order to find definitions. This can be a long process.
Previously, this query brought up a popup window that could be cancelled. However, this is confusing users since the query is automatically cancelled when the mouse hovers away from the element.
The downside of this PR is that even when find definitions is explicitly invoked, (using F12), there will still be no hover.
I think this is an improvement, but I am happy to discuss if others disagree.
Replace this with a description of the changes your pull request makes.
Checklist
ready-for-doc-reviewlabel there.