Remove feature flags for release v1.11.0#3128
Merged
Conversation
robertbrignull
approved these changes
Dec 12, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
The code changes and deleted code looks good to me.
I haven't tried running it but I trust you have tested it, and also we'll be doing some testing before the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the "feature flags" for the CodeQL method modeling and multiple models per method. Both already had their actual feature flags removed but were still behind canary. This removes that check and removes old code that is now unused.
Checklist
ready-for-doc-reviewlabel there.