Stop allowing running MRVA with query outside of workspace#3302
Merged
Stop allowing running MRVA with query outside of workspace#3302
Conversation
robertbrignull
approved these changes
Jan 31, 2024
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM assuming we have agreement that we want this behaviour change
Co-authored-by: Robert <robertbrignull@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently allow users to run a MRVA with a query that is not in their workspace. However, this can become problematic, specially when adding multi-query support.
In this change we introduce a restriction where users cannot run a MRVA if the query is not in their workspace.
Checklist
TODO:
ready-for-doc-reviewlabel there.