Merged
Conversation
d8dd34a to
bb23de9
Compare
koesie10
reviewed
Apr 2, 2024
Member
koesie10
left a comment
There was a problem hiding this comment.
Thanks for looking into this! I think we should be more lenient on the include/exclude properties, but the other changes look good to me.
This schema was incorrectly tagging `defaultSuite` properties that aren't arrays as errors. I think there are more, similar errors in this schema, but I only fixed this one so that I can get `github/semmle-code` working with test discovery.
d643f82 to
44c3c29
Compare
koesie10
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This schema was incorrectly tagging
defaultSuiteproperties that aren't arrays as errors. The error that needs to be fixed is that the CLI leniently reads yaml. Any property that is typed as an array in the schema is also acceptable as a single element.For example, the
defaultSuitecan either be an array of instructions or a single instruction.There are also missing fields in the qlpack type, but I don't think that matters for schema validation.
Note that this fixes a bug in the test explorer where qlpacks with
defaultSuiteproperties that are not arrays would cause the test explorer to avoid showing any test cases in that qlpack.Checklist
ready-for-doc-reviewlabel there.