Report progress for post-evaluation actions#3622
Merged
Conversation
aeisenberg
approved these changes
May 24, 2024
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Nice. LGTM. Can you add a changelog entry for this?
I wonder (and this is unrelated to your change) if we can summarize the evaluator logs in the background after showing the results for the query. There's no reason why the results view should be blocked while we're summarizing evaluator logs.
Generating and parsing log summaries can be quite slow, so we should update the progress window with messages about what's being worked on.
c82f406 to
b43b1d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating and parsing log summaries can be quite slow, so we should update the progress window with messages about what's being worked on.
I don't really know TypeScript, so there may be a nicer way of achieving what I've done here. 🤷
Checklist
ready-for-doc-reviewlabel there.