Skip to content

Remove feature flag for Python model editor#3676

Merged
koesie10 merged 2 commits intomainfrom
koesie10/remove-python-ff
Aug 1, 2024
Merged

Remove feature flag for Python model editor#3676
koesie10 merged 2 commits intomainfrom
koesie10/remove-python-ff

Conversation

@koesie10
Copy link
Copy Markdown
Member

This removes the feature flag codeQL.model.enablePython config setting and enables the Python model editor for everyone.

export function isSupportedLanguage(
language: QueryLanguage,
modelConfig: ModelConfig,
_modelConfig: ModelConfig,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left this parameter here for now since it's likely we'll be adding new languages at some point in the future with a feature flag.

@koesie10 koesie10 marked this pull request as ready for review July 31, 2024 09:33
@koesie10 koesie10 requested review from a team as code owners July 31, 2024 09:33
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@koesie10 koesie10 merged commit 1a59467 into main Aug 1, 2024
@koesie10 koesie10 deleted the koesie10/remove-python-ff branch August 1, 2024 09:43
@dbartol dbartol mentioned this pull request Aug 6, 2024
@github github deleted a comment May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants