Display length of shortest path in local results UI#3687
Merged
aeisenberg merged 2 commits intogithub:mainfrom Aug 12, 2024
Merged
Display length of shortest path in local results UI#3687aeisenberg merged 2 commits intogithub:mainfrom
aeisenberg merged 2 commits intogithub:mainfrom
Conversation
aeisenberg
reviewed
Aug 12, 2024
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Nice. Thanks for doing this. One minor change to the changelog entry and then 👍🏼.
p-
commented
Aug 12, 2024
extensions/ql-vscode/src/view/results/__tests__/AlertTableResultRow.spec.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Member
Author
|
@aeisenberg wow thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR implements the my feature request from #3659 for local path queries.
I'm totally open for changes of course (e.g. visualize it differently etc.)
The changes currently look like this:
(a badge showing the shortest path (
4or12here in this screenshot) was added and the length of the paths is shown on the respective entries in parentheses (e.g.(12 steps)). Additionally, a tooltipShortest pathis shown when hovering over the badge)Note:
mockresults.tsfrom this story.