Add a version-check to BigInt quick-eval test#3760
Merged
d10c merged 2 commits intogithub:mainfrom Oct 15, 2024
Merged
Conversation
Closed
Contributor
Author
|
Tests pass on older CLI versions: https://github.com/github/vscode-codeql/actions/runs/11343913756 This PR is ready to merge pending approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3759
Fixes a problem in #3647 where the tests did not pass under older CLI versions.
This separates the BigInt code into its own file and quick-evals it only on CLI versions that support
QlBuiltins::BigInt.