Allow import all database subfolders by selecting a folder#3797
Merged
aeisenberg merged 17 commits intogithub:mainfrom Nov 19, 2024
Merged
Allow import all database subfolders by selecting a folder#3797aeisenberg merged 17 commits intogithub:mainfrom
aeisenberg merged 17 commits intogithub:mainfrom
Conversation
7f0e8bc to
1196902
Compare
aeisenberg
reviewed
Nov 12, 2024
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I've given it an initial review, but I haven't tried this out locally yet.
Contributor
Author
|
I seperated this logic out of original import folder function for better structure. Also optimized log output and unified names of this command for better understanding. |
aeisenberg
reviewed
Nov 13, 2024
Contributor
Author
|
Done here. |
aeisenberg
reviewed
Nov 19, 2024
reitowo
commented
Nov 19, 2024
Comment on lines
+367
to
+370
| return withProgress(async (progress) => { | ||
| await this.chooseDatabasesParentFolder(progress); | ||
| }); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@aeisenberg Updated according to your suggestions with minor refine.
I also removed the title of this progress bar, because otherwise the whole message will be too long and doesn't display the actual step message of each database.
Currently will be:
Before:
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
1fac1b1 to
8b3add8
Compare
aeisenberg
reviewed
Nov 19, 2024
Contributor
|
I added one more update to the changelog and then it is ready to merge. |
aeisenberg
approved these changes
Nov 19, 2024
Contributor
Author
|
Thanks! |
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a palette command that allow user to select a folder and import all database subfolders.
This helps a lot when dealing with micro services that has dozens of databases and save user's time from repeatly choosing folders one by one.