Add support for (de-)registering databases with the query server#681
Add support for (de-)registering databases with the query server#681aeisenberg merged 4 commits intogithub:mainfrom
Conversation
|
TODO: Ensure there is a version check before attempting to add or remove from the allow list. Older versions of the cli do not support this feature. |
|
This was closed by mistake. |
|
Reopening. |
dab141c to
7e01187
Compare
7e01187 to
6fbfa82
Compare
d5ca54a to
608e373
Compare
|
Ping @github/docs-content-dsp! With this change (and the corresponding change in the CLI) we ensure that databases removed from the workspace are unlocked and can be queried without restarting vscode. This is more of a bug fix than a new feature, so not sure if we need a new entry in the docs or if a mention in the changelog is sufficient. Oh, and requires cli version 2.4.1 or later (so, not yet released). |
608e373 to
4ee1522
Compare
|
No docs impact! |
📚 Thanks for the docs ping! 🛎️ This was added to our docs first-responder project board. A team member will be along shortly to review this for docs impact, but you can also open a docs issue to request docs updates.
Thanks for the ping! You're right it's more of a bug fix, so a changelog entry should be sufficient 😊 |
Database registration is available in versions >= 2.4.1
4ee1522 to
3144915
Compare
adityasharad
left a comment
There was a problem hiding this comment.
Generally looks good!
And do a version check before adding `--require-db-registration` flag.
Sends commands to the query server to add and remove databases from the allow list. This feature will enable proper unlocking of databases when they are removed from vscode.
Fixes #572
Fixes #333
Fixes #249
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.