Add View AST Command to text editor where appropriate#712
Merged
aeisenberg merged 2 commits intogithub:mainfrom Dec 17, 2020
Merged
Add View AST Command to text editor where appropriate#712aeisenberg merged 2 commits intogithub:mainfrom
aeisenberg merged 2 commits intogithub:mainfrom
Conversation
Also, hide the `CodeQL: Run Queries` command inside of zip folders since we do not allow queries to be in archives. I wish we could be more specific about when to show that command, eg- only *.ql files and directories, but I couldn't find a way to restrict a command to only appear on directories.
b808cdc to
ee1ad90
Compare
adityasharad
approved these changes
Dec 17, 2020
Contributor
adityasharad
left a comment
There was a problem hiding this comment.
Nice and simple! One doc suggestion.
extensions/ql-vscode/CHANGELOG.md
Outdated
| - Avoid error dialogs when QL test discovery or database cleanup encounters a missing directory. [#706](https://github.com/github/vscode-codeql/pull/706) | ||
| - Add descriptive text and a link in the results view. [#711](https://github.com/github/vscode-codeql/pull/711) | ||
| - Fix the _Set Label_ command in the query history view. [#710](https://github.com/github/vscode-codeql/pull/710) | ||
| - Add the _CodeQL: View AST_ directly to text editors of files in database archives. [#712](https://github.com/github/vscode-codeql/pull/712) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Add the _CodeQL: View AST_ directly to text editors of files in database archives. [#712](https://github.com/github/vscode-codeql/pull/712) | |
| - Add the _CodeQL: View AST_ command to the right-click context menu when a source file in a database source archive is open in the editor. [#712](https://github.com/github/vscode-codeql/pull/712) |
Clarify a few entries.
173d597 to
23826a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, hide the
CodeQL: Run Queriescommand inside of zip folderssince we do not allow queries to be in archives. I wish we could be more
specific about when to show that command, eg- only *.ql files and
directories, but I couldn't find a way to restrict a command to only
appear on directories.
Fixes #707
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.