Fix issues with dynamic updating of the version status bar item#754
Merged
aeisenberg merged 1 commit intogithub:mainfrom Feb 12, 2021
Merged
Fix issues with dynamic updating of the version status bar item#754aeisenberg merged 1 commit intogithub:mainfrom
aeisenberg merged 1 commit intogithub:mainfrom
Conversation
35bb16a to
c33ff22
Compare
adityasharad
approved these changes
Feb 12, 2021
| // Wait a few seconds before updating the status item. | ||
| // This avoids a race condition where the cli's version | ||
| // is not updated before the status bar is refreshed. | ||
| setTimeout(() => this.updateStatusItem(), 3000); |
Contributor
There was a problem hiding this comment.
setTimeout makes this non-blocking right?
1. Wait a few seconds before updating the status bar after a version change. 2. Ensure we are watching the correct configuration items for changes. 3. Ensure the cli version is refreshed correctly.
c33ff22 to
f1f596d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.