Add feature to jump to the .ql file referenced by a .qlref#815
Add feature to jump to the .ql file referenced by a .qlref#815aeisenberg merged 2 commits intogithub:mainfrom
Conversation
aeisenberg
left a comment
There was a problem hiding this comment.
This looks great. Let's get the related PR in semmle-code merged and then we can merge this one.
b9745d9 to
d07b4ef
Compare
|
Updated to account for the minor CLI changes in the internal PR, which has now been merged. This is now ready for merging, although doing so will mean we should not release a new version of the extension until the new CLI is released. |
aeisenberg
left a comment
There was a problem hiding this comment.
This looks good and can is ready to be merged, but I think you're right that we should hold off for now until cli v2.5.1 is released. It would be annoying if you got this message and had no way of upgrading to a sufficient version.
| helpers.showAndLogErrorMessage( | ||
| 'Jumping from a .qlref file to the .ql file it references is not ' | ||
| + 'supported with the CLI version you are running.\n' | ||
| + 'Please upgrade your CLI to use this feature.'); |
There was a problem hiding this comment.
Would be nice to include the minimum cli version here. Something like:
| + 'Please upgrade your CLI to use this feature.'); | |
| + `Please upgrade your CLI to version ${CLI_VERSION_WITH_RESOLVE_QLREF} or later to use this feature.`); |
This PR adds an option to jump from a
.qlreffile to the.qlfile it references. Note that it should not be merged yet, as it relies on a new CLI callresolve qlrefwhich is not released yet.Closes #654