Forward all query metadata to the queryserver#838
Merged
henrymercer merged 3 commits intogithub:mainfrom Apr 21, 2021
henrymercer:henrymercer/forward-all-query-metadata
Merged
Forward all query metadata to the queryserver#838henrymercer merged 3 commits intogithub:mainfrom henrymercer:henrymercer/forward-all-query-metadata
henrymercer merged 3 commits intogithub:mainfrom
henrymercer:henrymercer/forward-all-query-metadata
Conversation
aeisenberg
reviewed
Apr 21, 2021
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
This looks fine. But just want to be sure that if a user accidentally includes invalid metadata, will the interpretation fail?
Contributor
Author
|
We currently generate metadata errors in (at least) two places: the metadata verifier, which is invoked during compilation, and the interpretation itself. For VS Code, only the metadata errors during the interpretation itself are problematic. I don't believe there are any cases where forwarding additional metadata would make the interpretation start failing. |
aeisenberg
approved these changes
Apr 21, 2021
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Thanks for the clarification. Yes, I think this needs a changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR forwards all the query metadata to the queryserver.
Currently, only
@kindand@idare forwarded for most users. This results in metadata errors when running some queries, even if the queries being run had the correct metadata. For example, the@kind metricquery requires either the@tags summarymetadata or the@metricTypemetadata key to be defined. However the VS Code extension doesn't currently forward the@tagsand@metricTypeproperties, so the queryserver reports errors whenever a user tries to run these queries.With this PR, we forward all the query metadata to the queryserver, so queries like these will no longer report metadata errors.
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.