Watch for changes in directory structure#846
Merged
aeisenberg merged 2 commits intogithub:mainfrom Apr 23, 2021
Merged
Conversation
This ensures that directories renamed, added or deleted are properly checked to see if they contain tests. The test tree will be correctly updated when any directory changes.s
| // Watch for changes to any `.ql` or `.qlref` file in any of the QL packs that contain tests. | ||
| this.watcher.addWatch(new RelativePattern(results.watchPath, '**/*.{ql,qlref}')); | ||
| // need to explicitly watch for changes to directories themselves. | ||
| this.watcher.addWatch(new RelativePattern(results.watchPath, '**/')); |
Contributor
There was a problem hiding this comment.
So this is all directories under a workspace folder? Any noticeable hit to performance on a large repo? Do we need to exclude database source archives?
Contributor
Author
There was a problem hiding this comment.
Nothing noticeable. I renamed the ql folder that is a submodule in the starter repo and there was no noticeable lag in the file explorer. The test explorer itself took a few seconds to update, but I think that's fair because it needs to re-discover the entire tree.
We don't need to do any special handling for source archives since they are readonly and aren't watched for changes.
adityasharad
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that directories renamed, added or deleted are
properly checked to see if they contain tests. The test tree
will be correctly updated when any directory changes.s
Fixes #799.
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.