Improve LGTM download messages#852
Merged
aeisenberg merged 5 commits intogithub:mainfrom Apr 29, 2021
Merged
Conversation
aeisenberg
reviewed
Apr 28, 2021
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Do you think this sounds better?
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
aeisenberg
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #813 (commit 6c81212). I've expanded the LGTM download message to prompt users to choose a language:
👆🏽 This doesn't apply to all databases, hence "if available". (I hope that's clear enough, but otherwise we can try to only display this message for multi-language databases. I haven't looked at how to do this yet 🙇🏽♀️)
(281084e fixes some minor typos.)
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.