Skip to content

[🚧 WIP 🚧] Fix dependabot alerts#883

Closed
shati-patel wants to merge 1 commit intogithub:mainfrom
shati-patel:update-dependencies
Closed

[🚧 WIP 🚧] Fix dependabot alerts#883
shati-patel wants to merge 1 commit intogithub:mainfrom
shati-patel:update-dependencies

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Jun 16, 2021

Coming back to this now that #882 is merged 🎉

See https://github.com/github/vscode-codeql/security/dependabot. I ran npm audit fix as a starting point, but this might need definitely needs some manual work too.

Checklist

N/A

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@shati-patel shati-patel changed the title Fix dependabot alerts [🚧 WIP 🚧] Fix dependabot alerts Jun 18, 2021
@shati-patel shati-patel force-pushed the update-dependencies branch from 3e47e88 to 92fb72b Compare June 23, 2021 09:36
@aeisenberg
Copy link
Copy Markdown
Contributor

Hmmm...taking a look at this now, and I think our best bet is to wait a few more days to fix. The high vulnerability is from gulp-parent, which is only used during build, so doesn't affect production.

Also, there is no fixed version of this available yet, so we need to downgrade to get a safe version. Hopefully, the gulp team will address the problem and put out a new release soon. In that case, it will be easier to fix this dependabot issue.

If no fix comes in a few weeks, we should downgrade to gulp v3.9.x which is the latest safe version, though might be a bit of a pain.

@shati-patel
Copy link
Copy Markdown
Contributor Author

Hmmm...taking a look at this now, and I think our best bet is to wait a few more days to fix. The high vulnerability is from gulp-parent, which is only used during build, so doesn't affect production.

Also, there is no fixed version of this available yet, so we need to downgrade to get a safe version. Hopefully, the gulp team will address the problem and put out a new release soon. In that case, it will be easier to fix this dependabot issue.

If no fix comes in a few weeks, we should downgrade to gulp v3.9.x which is the latest safe version, though might be a bit of a pain.

Thanks for taking a look! ✨ I'll close this PR for now, and hopefully there'll be a patched version of gulp soon 🤞🏽

@shati-patel shati-patel deleted the update-dependencies branch August 10, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants