New command to add database source folder to workspace#891
Merged
aeisenberg merged 3 commits intomainfrom Jun 25, 2021
Merged
Conversation
Contributor
|
Good point about users explicitly removing the source folder. |
aeisenberg
reviewed
Jun 25, 2021
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Nicely done. This should have a changelog entry and then we can merge it.
Contributor
Author
Thanks for the review! I've checked the docs for changes (none needed) and updated the changelog 📝 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will fix #798.
As described in the linked issue, we don't have an easy way of re-adding a database's source folder to the workspace. This PR adds a new command (in the Databases View) that lets you re-add a source folder.
(We also considered re-adding source folders automatically, similar to how the
codeQLDatabases.removeOrphanedDatabasescommand is run, but I'm now wondering if that'll be annoying to users. They may have deliberately removed a source folder from their workspace, and don't want it included automatically 🤔 I'm open to suggestions though!)PS: In the process, I found a small bug in how we upgrade databases. (Opened an issue here #890, but haven't worked out how to fix that yet! 😅)
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.